run parallel tool calls in parallel #113
Merged
+34
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/lisette/pull/113 |
Contributor
|
FYI @KeremTurgutlu there wasn't any error handling in the parallel tool calls, so any 1 exception caused them all to fail. We'll add a param to return the error instead of raising it. Also if there's only one call, we'll set n_workers to |
Contributor
Author
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parallel tool calls were being executed sequentially in both
ChatandAsyncChat. Now:AsyncChat: tool calls run concurrently viaasyncio.gather(works with both sync and async tools, paired with run sync tools with threads incall_func_asynctoolslm#73)Chat: tool calls run in parallel viafastcore.parallelwith threadsNote: the toolslm change isn't required for solveit as it already wraps tool functions as async, but it enables parallel sync tool execution for other lisette users.
Screen.Recording.2026-02-09.at.7.03.24.PM.mov
Test dialog: https://share.solve.it.com/d/918a419b8dfa68fc11505a7e6311455c
Fixes #112